-Wcast-qual Re: [PATCHES v4] Another round of FreeBSD developer build fixes

Andrew Bartlett abartlet at samba.org
Sat Nov 25 03:30:01 UTC 2017

On Sat, 2017-11-25 at 00:37 +0200, Uri Simchoni wrote:
> On 11/24/2017 02:09 AM, Andrew Bartlett via samba-technical wrote:
> > I don't really like
> > 
> > [PATCH v4 01/13] s4-cli: increment once in the for loop
> What do you have in mind? I agree with the compile that incrementing
> both in the for-loop and inside the loop is not very good - people
> looking at the code might miss the increment. Shall we transform it into
> a while loop?

I'm not sure.  In trying to get as much of your patches in so a
reasonable discussion could be had of the remainder, I've set a high
bar for 'I clearly understand what this patch is trying to do and why'
and a high sensitivity for 'gut feeling'.  

It isn't an objection in that sense, mostly me putting it off hoping
someone else solves it for me.  

> > I would like some broader comment on:
> > 
> > [PATCH v4 08/13] build: remove -Wcast-align from developer build
> > 
> That commit message was already considerably longer than the average
> commit message. Following is a broader commit message, please tell if
> this is closer to what you had in mind.

It is more that I would like comment from someone like metze before
removing a check we thought we had 'just' to build on a new compiler.  

I like the explanation, and agree with you, but I as there isn't a rush
I'm looking for broader comment. 

Also, if this rule is violated on these platforms, does the kernel fix
it up or is this SIGBUS?


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list