[PATCHES v4] Another round of FreeBSD developer build fixes

Günther Deschner gd at samba.org
Fri Nov 24 15:37:19 UTC 2017

Hi Uri,

with the vfs_full_audit patch in that patchset I now get these build

../source3/modules/vfs_full_audit.c: In function ‘smb_full_audit_set_quota’:
../source3/modules/vfs_full_audit.c:722:54: error: zero-length
gnu_printf format string [-Werror=format-zero-length]
  do_log(SMB_VFS_OP_SET_QUOTA, (result >= 0), handle, "");

when building with --picky-developer on fedora27.

Could you have a look?


On 23/11/17 23:58, Uri Simchoni via samba-technical wrote:
> Hi,
> After Andrew committed some of the FreeBSD build fixes, here's another
> round of reduced patch set. It includes:
> - Patches which were not explicitly nacked but did not land yet
> - Reworked pam_wrapper patches, already upstream and reviewed by Andreas
> - Reworked pragma-less handling of readline.h issues, according to tip
> by Timur Bakeyev
> It does not include parts of the original patch set which still require
> rework:
> - the sysacls patch (v3 1/38) which Andrew felt was smelly - after
> closer examination I think it would have broken other
> non-Linux/nop-FreeBSD builds.
> - remaining #pragma-bearing patchs in pam_winbind (v3 13/38 and 14/38)
> Review appreciated,
> Uri.

Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 216 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171124/a0f32c67/signature.sig>

More information about the samba-technical mailing list