[PATCH] Add substitutions %t, %j, and %J as path-safe variants of %T, %i, and %I.

Andrew Bartlett abartlet at samba.org
Thu Nov 23 20:43:15 UTC 2017


On Thu, 2017-11-23 at 20:07 +0100, Dr. Thomas Orgis via samba-technical 
wrote:
> Rationale: Using the existing substitutions in construction of paths
> (dynamic shares, created on client connect) results in directory names with
> colons and dots in them. Those can be hard to use when accessed from a
> different share, as Windows does not allow : in paths and has some ideas about
> dots.

G'Day Thomas,

This is an interesting addition.  Could you add some tests for it?

Here are some potential tests to extend:

source3/torture/torture.c:run_local_substitute()

source3/script/tests/test_substitutions.sh
(which uses the sub_dug and sub_dug2 shares defined in
selftest/target/Samba3.pm)

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list