[PATCH] run-time and dbcheck time wrong backlink handling

Stefan Metzmacher metze at samba.org
Thu Nov 23 14:44:35 UTC 2017

Hi Andrew,

>>> I'll try to combine it with my dbcheck patches to fix
>>> the consequences of https://bugzilla.samba.org/show_bug.cgi?id=13095
>>> See
>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
>>> v4-6-duplicate-links
>>> and
>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
>>> v4-7-duplicate-links
>> I've tried to forward-port that to master, which was a mission, but I
>> think I've done it.  More importantly I've improved the tests, and
>> found it handles one issue I couldn't get the old dbcheck to find,
>> which is a backlink to a deleted object.
>> The tests have been changed to use administrator and enterprise admins
>> to keep stable GUIDs, and now reliably pass.
>> There is still more work to do to squash this in to a for-master patch
>> series, and I may have totally mucked up the rebase, so please look
>> carefully.
>> I wouldn't normally get into your WIP tree, but it seemed more helpful
>> than continuing parallel development.
>> Thanks for all your work here, and I hope this is useful!
>> http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/abartlet-dbcheck-links-2017-11
> G'Day,
> I've updated that branch, and now have patches covering runtime as well
> as dbcheck-time behaviour.  In particular, I can now cope with deleting
> objects that had backlinks that we can assert are faulty (object
> tomebstoned or missing).
> I was hoping to get these fixes in to 4.7.1 but I think I'm too late
> for that, but if you can help get these in to master that would be
> great.  I've tried un-tangling it again from your code but that just
> looks like being more difficult all-round.
> If you could take a look at what I've done and finish tidying up your
> patches that would be great.  If you could fix the existing failure in
> dbcheck-links.dbcheck_dangling_multi_valued_clean that would be even
> better!
> The output is below, hidden normally because it is in knownfail.

Thanks! I cleaned up my patches and squashed a few things.


I left the last 4 unsquashed for further review from you.

We also need some more BUG: lines here and there.

contains backports

I'm currently running private autobuilds with both branches.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171123/5e452135/signature.sig>

More information about the samba-technical mailing list