[PATCHES] pam_wrapper: fix some clang/FreeBSD picky-developer warnings

Andreas Schneider asn at samba.org
Thu Nov 23 14:10:04 UTC 2017

On Wednesday, 22 November 2017 22:24:08 CET Uri Simchoni via samba-technical 
> Hi,

Hi Uri,
> This patch set contains patches for upstream pam_wrapper, concerning
> fixes to FreeBSD picky-developer build. An accompanying patch has been
> reviewed and fixed by Andreas already.
> About the conversion from a variable to a macro - yes that's contrary to
> what they teach us (particularly in C++ school), but one has to remember
> that the reason for deprecation of macros is that tools don't handle
> them intelligently - well, here's a case where at least a particular
> compiler handles macros more intelligently than a variable... (tried
> const without the static - in C++ that should have done the trick, no
> luck either :( )
> Please review and maybe push...

thanks for the patches. I pushed them upstream.


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list