[PATCHES v2] Fix FreeBSD developer build

[Stefan Metzmacher]

Am 22.11.2017 um 21:05 schrieb Uri Simchoni:
> On 11/22/2017 03:02 PM, Stefan Metzmacher wrote:
>>
>> I'm not so happy with the cflags_end change.
>> Shouldn't we fix pidl to avoid generating unused functions?
>>
>> I'm also wondering what an actual example error message is.
>> As I guess we already make sure we don't have any unused static
>> functions with the master autobuild.
>>
> 
> Here's the build result with the patch removed:
> 
> [1836/3977] Compiling default/librpc/gen_ndr/py_misc.c
> default/librpc/gen_ndr/py_misc.c:34:25: error: unused function
> 'ndr_sizeof2intmax' [-Werror,-Wunused-function]
> static inline long long ndr_sizeof2intmax(size_t var_size)
>                         ^
> default/librpc/gen_ndr/py_misc.c:50:25: error: unused function
> 'ndr_PyLong_FromLongLong' [-Werror,-Wunused-function]
> static inline PyObject *ndr_PyLong_FromLongLong(long long v)

I think we should move this to a header file instead of generating it in
each file.

Is there some documentation of the clang warnings?
the gcc manpage says that 'static inline' functions are not subject of
-Wunused-function

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171123/4f207fcb/signature.sig>