[PATCH] vfs_fruit: conversion of FinderInfo from AppleDouble files

Jeremy Allison jra at samba.org
Mon Nov 20 23:18:26 UTC 2017

On Mon, Nov 20, 2017 at 01:45:44PM -0800, Jeremy Allison via samba-technical wrote:
> On Mon, Nov 20, 2017 at 10:22:08PM +0100, Ralph Böhme via samba-technical wrote:
> > On Mon, Nov 20, 2017 at 06:54:24AM -0700, David Mulder wrote:
> > > RB+
> > 
> > thanks David! Can I get a second team member to review as well please?
> Looking over it now....

Ralph, with this patch and doing:

make test TESTS=samba3.vfs.fruit

I get:

ERROR: Testsuite[samba3.vfs.fruit metadata_netatalk(nt4_dc)]
REASON: Exit code was 1

[2(25)/5 at 32s, 1 errors] samba3.vfs.fruit metadata_stream(nt4_dc)
Enabling AAPL
Comparing returned AAPL capabilities
Preparing file
Issue find
Checking find response with enriched macOS metadata
UNEXPECTED(failure): samba3.vfs.fruit metadata_stream.readdir_attr with names with illegal ntfs characters(nt4_dc)
REASON: Exception: Exception: ../source4/torture/vfs/fruit.c:3990: d[i].id_both_directory_info.name.s was ._test\uf022aapl, expected test\uf022aapl: bad name
envlog: SMBD LOG of: LOCALNT4DC2
fruit_streaminfo_meta_stream: Removing invalid AFPINFO_STREAM size [3] from [filtest_invalid_afpinfo]

Can you check this out ?



More information about the samba-technical mailing list