[PATCHES v2] Fix FreeBSD developer build (was: Re: vfs_zfsacl.c: use of undeclared identifier 'ace')

Andrew Bartlett abartlet at samba.org
Mon Nov 20 23:16:54 UTC 2017

On Mon, 2017-11-20 at 23:58 +0100, Timur I. Bakeyev via samba-technical 
> Hi, Uri!
> That's quite a jumbo patch, possibly splitting it into smaller chunks could
> be easier to review :)
> I've noticed mentioning of missing HAVE_INTPTR_T on FreeBSD, need to check
> that, but meanwhile:
> https://bugzilla.samba.org/show_bug.cgi?id=4635
> Also, is that patchset against the HEAD? As traditionally we usually first
> work with releases, so at least two patches fail to me...

Samba patches are generally developed against master, backports are a
secondary task as they need the git hash from master for the cherry-

On the question of how to keep this working, one option might be to get
Travis CI building Samba on MacOS, that might be close enough to cover
some of the issues.  That doesn't stop patches get into master, but at
least it can be monitored by watching the build status on GitHub / pull


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list