[PATCH] pthreadpool: create a tevent_threaded_context per registered event context
jra at samba.org
Thu Nov 16 18:39:17 UTC 2017
On Thu, Nov 16, 2017 at 07:31:31PM +0100, Ralph Böhme wrote:
> On Thu, Nov 16, 2017 at 10:14:27AM -0800, Jeremy Allison wrote:
> > On Tue, Nov 14, 2017 at 04:35:40PM +0100, Ralph Böhme wrote:
> > > Hi!
> > >
> > > Attached is a patch that enhances pthreadpool_tevent to create one
> > > tevent_threaded_context per registered event context instead of per
> > > pthreadpool_tevent_job_send request.
> > >
> > > Please review carefully -- the rundown is a bit tricky -- and push if
> > > happy. Thanks!
> > >
> > > Fwiw: it passed two private autobuilds and it survives smbtorture
> > > local.messaging tests with a modified messaging subsystem that sends out all
> > > messages via helper threads.
> > OK, how about this version. That actual code is exactly as you
> > posted, all I've done is thoroughly commented it such that if
> > I had to maintain this I'd know immediately what it was doing :-).
> > Let me know if this is OK !
> awesome! Thanks a lot!
> I actually think this deserves a pair-programmed-with: you and a signed-off-by:
> you. Let me know you're ok with this change.
Sure, if you want to that's OK - but it's not required :-).
More information about the samba-technical