Bug in ctdb_recovery_helper ?

[Ralph Böhme]

On Sun, Nov 12, 2017 at 11:50:41AM +1100, Amitay Isaacs wrote:
> Hi Ralph,
> 
> On Sun, Nov 12, 2017 at 2:08 AM, Ralph Böhme <slow at samba.org> wrote:
> 
> > Hi Amitay,
> >
> > while going through ctdb_recovery_helper I noticed that in
> > recovery_active_done() we count the number of nodes but neither use it in
> > afterwards in this function nor anywhere else as we don't update the state
> > with
> > the new count. Is this by design or a bug?
> >
> >
> In recovery_active_done(), "count" local variable is for number of nodes
> in the vnnmap (active lmasters).  The variable state->count is for active
> nodes in the nodemap.
> 
> This is by design.

ok, thanks.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/