[PATCH] pthreadpool: create a tevent_threaded_context per registered event context

Jeremy Allison jra at samba.org
Thu Nov 16 01:03:03 UTC 2017

On Wed, Nov 15, 2017 at 04:30:28PM -0800, Jeremy Allison via samba-technical wrote:
> On Tue, Nov 14, 2017 at 04:35:40PM +0100, Ralph Böhme wrote:
> > Hi!
> > 
> > Attached is a patch that enhances pthreadpool_tevent to create one
> > tevent_threaded_context per registered event context instead of per
> > pthreadpool_tevent_job_send request.
> > 
> > Please review carefully -- the rundown is a bit tricky -- and push if
> > happy. Thanks!
> > 
> > Fwiw: it passed two private autobuilds and it survives smbtorture
> > local.messaging tests with a modified messaging subsystem that sends out all
> > messages via helper threads.
> FYI, I'm reviewing this now, although it will take me a while
> to make sure I understand it before giving a +1 :-).

OK, I understand what this is doing. But I would really like
a version that has *copious* comments to aid anyone looking
at this code rather than having to figure it out from the
talloc heirarchies like I just did :-) :-).

Can you give me a day to add those comments and re-submit
it back to you for checking that they make sense and I really
did understand it ? :-).



More information about the samba-technical mailing list