vfs_zfsacl.c: use of undeclared identifier 'ace'

[Youzhong Yang]

I don't disagree. But FreeBSD does ship zfsacl.so: 

/usr/local/lib/shared-modules/vfs/zfsacl.so

Last month or so I've been playing with Linux (Centos, Ubuntu) and FreeBSD, in terms of tracing and debugging, Solaris/illumos is still unbeatable. If FreeBSD can have 'mdb' integrated, it would be very attractive. I know someone is working on it ...

Anyway, it's not a place to debate which OS is good or bad. For Solaris/illumos, can I volunteer to be the tester? We can try to have some retired hardware dedicated for this purpose. I'd like to try my best to make this happen, although I cannot guarantee the resource and my time. Please let me know.

Best,

--Youzhong

-----Original Message-----
From: Jeremy Allison [mailto:jra at samba.org] 
Sent: Monday, November 13, 2017 1:25 PM
To: Youzhong Yang <Youzhong.Yang at mathworks.com>
Cc: Ralph Böhme <slow at samba.org>; samba-technical at lists.samba.org
Subject: Re: vfs_zfsacl.c: use of undeclared identifier 'ace'

On Sat, Nov 11, 2017 at 11:39:40PM +0000, Youzhong Yang via samba-technical wrote:
> Thanks, it fixes the compilation error.
> 
> I appreciate Samba team's efforts/contributions. But as an outsider, just a little bit concerned - it seems code change/fix is so easy to get into the system, without adequate review/testing.

Not really. zfsacls are not shipped on the majority of platforms, so it's hard to have regression tests for code that most people can't compile.

It's impossible to get compilation errors into mainline where regression tests ensure quality.