vfs_zfsacl.c: use of undeclared identifier 'ace'

Jeremy Allison jra at samba.org
Mon Nov 13 18:25:20 UTC 2017

On Sat, Nov 11, 2017 at 11:39:40PM +0000, Youzhong Yang via samba-technical wrote:
> Thanks, it fixes the compilation error.
> I appreciate Samba team's efforts/contributions. But as an outsider, just a little bit concerned - it seems code change/fix is so easy to get into the system, without adequate review/testing.

Not really. zfsacls are not shipped on the majority of
platforms, so it's hard to have regression tests for code
that most people can't compile.

It's impossible to get compilation errors into mainline where regression
tests ensure quality.

More information about the samba-technical mailing list