[PATCH] fix two resource leaks

Andreas Schneider asn at samba.org
Mon Nov 13 07:53:30 UTC 2017


Hi,

attached is a small patchset to fix two resource leaks.


Review and push is welcome!


Thanks,


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
>From 5152c8af076ed685798db246f5520de1d7062163 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Thu, 2 Nov 2017 21:48:21 +0100
Subject: [PATCH 1/2] vfs_fruit: Unlink memory on error

Signed-off-by: Andreas Schneider <asn at samba.org>
---
 source3/modules/vfs_fruit.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
index 78170e7abdd..15e42fb4dfd 100644
--- a/source3/modules/vfs_fruit.c
+++ b/source3/modules/vfs_fruit.c
@@ -1078,6 +1078,7 @@ static int ad_convert(struct adouble *ad,
 
 	ok = ad_convert_xattr(ad, smb_fname, map);
 	if (!ok) {
+		munmap(map, origlen);
 		return -1;
 	}
 
-- 
2.15.0


>From f635c822e4b944c20e3d68fc5b9b27c3e3fdefa4 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Thu, 2 Nov 2017 21:49:43 +0100
Subject: [PATCH 2/2] s3:passdb: Fix a memory leak in
 secrets_fetch_or_upgrade_domain_info()

Signed-off-by: Andreas Schneider <asn at samba.org>
---
 source3/passdb/machine_account_secrets.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/source3/passdb/machine_account_secrets.c b/source3/passdb/machine_account_secrets.c
index 75f31cb04e2..40511f96a8b 100644
--- a/source3/passdb/machine_account_secrets.c
+++ b/source3/passdb/machine_account_secrets.c
@@ -1476,6 +1476,7 @@ NTSTATUS secrets_fetch_or_upgrade_domain_info(const char *domain,
 		DBG_ERR("secrets_domain_info_password_create(pw) failed "
 			"for %s - %s\n", domain, nt_errstr(status));
 		dbwrap_transaction_cancel(db);
+		SAFE_FREE(old_pw);
 		TALLOC_FREE(frame);
 		return status;
 	}
-- 
2.15.0



More information about the samba-technical mailing list