[RFC] vfs_nfs4acl_xattr NFS4.1 support, support for XDR encoding and more...

Ralph Böhme slow at samba.org
Tue Nov 7 22:31:42 UTC 2017


On Tue, Nov 07, 2017 at 02:15:33PM -0800, Jeremy Allison wrote:
> > OK, RB+ and pushed with just one change, in make_default_acl_everyone()
> > you had:
> > 
> > struct security_ace aces[4];
> > 
> > which was cut-n-paste left over - we are only adding one
> > ace here so it should be:
> > 
> > struct security_ace aces[1];

good catch, thanks!

> Ah. On submission to autobuild it caught a use-before-initialize
> error I missed.

Hm, I wonder why that doesn't fail here with --pick-developer.

> Can you also fix the initialization errors below
> and re-submit ?

Attached.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/



More information about the samba-technical mailing list