It seems a bit savage to panic if an admin mistypes a [in]valid users entry

Richard Sharpe realrichardsharpe at gmail.com
Fri Nov 3 16:04:49 UTC 2017


Hi folks,

In looking at a netgroups question I noticed this in
source3/smbd/share_access.c token_contains_name:

                }
                smb_panic("got invalid prefix from do_groups_check");
        }

Should we really panic if an admin entered some invalid character.
That would lead to things failing in strange and hard to debug ways
...

Surely it is better to simply ignore that field/parameter?

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)



More information about the samba-technical mailing list