[RFC] vfs_nfs4acl_xattr NFS4.1 support, support for XDR encoding and more...

[Ralph Böhme]

On Thu, Nov 02, 2017 at 08:37:21AM -0700, Jeremy Allison wrote:
> On Thu, Nov 02, 2017 at 11:56:23AM +0100, Ralph Böhme wrote:
> > On Sun, Oct 29, 2017 at 09:28:46AM +1300, Andrew Bartlett wrote:
> > > On Sat, 2017-10-28 at 19:09 +0200, Ralph Böhme wrote:
> > > > On Fri, Oct 27, 2017 at 01:56:04PM -0700, Jeremy Allison wrote:
> > > > > On Fri, Oct 27, 2017 at 10:32:33PM +0200, Ralph Böhme wrote:
> > > > > > On Wed, Oct 25, 2017 at 10:59:38AM +0200, Ralph Böhme wrote:
> > > > > > > I'm in favour of changing the default for the old NDR backend as well. What do
> > > > > > > you think? Andrew? It's your code. :)
> > > > > > 
> > > > > > ping.
> > > > > > 
> > > > > > > > 4). [PATCH 22/25] vfs_nfs4acl_xattr: add XDR backend
> > > > > > > > In nfs4acl_get_xdrblob_size() - integer wrap checks
> > > > > > > > please on this:
> > > > > > > > size += nacl->na41_aces.na41_aces_len * sizeof(struct nfsace4);
> > > > > > > 
> > > > > > > Done. Thanks for spotting this! I hope I guarded all relevant places in the
> > > > > > > attached updated patchset.
> > > > > > 
> > > > > > Another ping. :=)
> > > > > 
> > > > > Next on my list to review once I've looked at the kernel
> > > > > oplock bugs, honest ! :-).
> > > > 
> > > > Oh, so I hope you come out of that in a sane state of mind. :)
> > > > 
> > > > > FYI. Is this merely a WIP, or do you want me to push if
> > > > > it passes review ?
> > > > 
> > > > Still waiting for feedback on the questions I brought up in the first mail, from
> > > > you and especially from Andrew as it's his code.
> > > > 
> > > > Andrew?
> > > 
> > > I'm fine with the concept - my role was to dispel the myth that this
> > > was un-testable, I'm not wedded to the NDR encoding. 
> > 
> > :-))) Just in case, I'm keeping the default encoding as NDR.
> > 
> > > I'm very happy for the defaults to change, I can't imagine it has been
> > > used in production.
> > 
> > Ok, I'll then follow-up with a patchset that changes the ACL version to 4.1 and
> > the xattr name to "security.nfs4acl_ndr" instead of "security.nfs4acl".
> 
> FYI. I'm reviewing your original patchset right now.
> 
> Do you want me to push if good, or shall I wait for a follow-up
> patchset ?

oh, please wait a few more hours. I'm currently runnig one more final full
private autobuild after changing the defaults.

Individual tests passed the raw.acls tests, just want to make sure the full
patchset survives a full autobuild, currently at

[1155(5855)/2211 at 1h15m11s] samba4.rpc.mgmt with validate(ad_dc_ntvfs)

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/