[PATCHES] GPO support for the AD DC (vers 5)

David Mulder dmulder at suse.com
Thu Nov 2 13:49:23 UTC 2017


This patch fixes the crash.
We should free the frame from all return cases in resolve_name()

On 11/01/2017 04:23 PM, Garming Sam wrote:
> Hi,
>
> Seen a failure in our test suites with the patches:
>
> [57(928)/2209 at 47m30s] samba.tests.tdb_util
> [58(929)/2209 at 47m31s] samba.tests.tdb_util.python3
> [59(930)/2209 at 47m31s] samba.tests.pam_winbind(local)(ad_member)
> ERROR: Testsuite[samba.tests.pam_winbind(local)(ad_member)]
> REASON: unable to set up environment ad_member - exiting
>
>
> Freed frame ../source3/utils/net.c:917, expected
> ../source3/libsmb/namequery.c:2871.
> PANIC (pid 30133): Frame not freed in order.
> BACKTRACE: 10 stack frames:
>  #0 bin/shared/libsmbconf.so.0(log_stack_trace+0x1f) [0x2b386416106e]
>  #1 bin/shared/libsmbconf.so.0(smb_panic_s3+0x6f) [0x2b3864160eb9]
>  #2 bin/shared/libsamba-util.so.0(smb_panic+0x28) [0x2b3863f60df8]
>  #3 bin/shared/libsamba-util.so.0(+0x25fe3) [0x2b3863f63fe3]
>  #4 bin/shared/private/libtalloc.so.2(+0x36a6) [0x2b38641bd6a6]
>  #5 bin/shared/private/libtalloc.so.2(+0x3a2c) [0x2b38641bda2c]
>  #6 bin/shared/private/libtalloc.so.2(_talloc_free+0x102)
> [0x2b38641bece7]
>  #7 ./bin/net(main+0xf24) [0x2b38637dc214]
>  #8 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
> [0x2b38658a7f45]
>  #9 ./bin/net(+0x246b9) [0x2b38637c26b9]
>
>
> It looks like the talloc stackframe work hasn't quite been completed.
> There seems be another location which has not yet been included.
>
>
> Cheers,
>
>
> Garming
>
>
> On 02/11/17 10:01, David Mulder via samba-technical wrote:
>> Here is a patch to improve the formatting.
>>
>> On 11/01/2017 01:08 PM, Andrew Bartlett wrote:
>>> On Thu, 2017-11-02 at 06:10 +1300, Andrew Bartlett via samba-technical
>>> wrote:
>>>> On Wed, 2017-11-01 at 11:01 -0600, David Mulder wrote:
>>>>> Oh, sorry. It actually all came through in a single email (labeled
>>>>> one
>>>>> of thirty).
>>>> Sorry, didn't scroll down ;-)
>>>>
>>>>> But it looks as though I missed a commit anyhow, since there
>>>>> should be 31 commits, not 30.
>>>>> Here is an attachment, and is posted to my github repo:
>>>>> https://github.com/dmulder/samba/tree/garming-gpo-david-rebased
>>>> Thanks!
>>> I've pushed it back to garming-gpo-david-rebased after some squashing.
>>>
>>> The diff is:
>>>
>>> diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
>>> index 38844e5a43e..4f53981ec83 100644
>>> --- a/libgpo/pygpo.c
>>> +++ b/libgpo/pygpo.c
>>> @@ -70,7 +70,7 @@ static PyObject *py_gpo_get_unix_path(PyObject
>>> *self, PyObject *args,
>>>          TALLOC_CTX *frame = NULL;
>>>          static const char *kwlist[] = {"cache_dir", NULL};
>>>          struct GROUP_POLICY_OBJECT *gpo_ptr \
>>> -               = pytalloc_get_type(self, struct GROUP_POLICY_OBJECT);
>>> +               = (struct GROUP_POLICY_OBJECT *)pytalloc_get_ptr(self);
>>>            if (!PyArg_ParseTupleAndKeywords(args, kwds, "|s",
>>> discard_const_p(char *, kwlist), &cache_dir)) {
>>>                  PyErr_SetString(PyExc_SystemError, "Failed to parse
>>> arguments to gpo_get_unix_path()");
>>>
>>>
>>> I'll try to get this reviewed into master during the next little while.
>>>
>>> Thanks,
>>>
>>> Andrew Bartlett
>>>
>

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: talloc.patch
Type: text/x-patch
Size: 696 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171102/69ae907c/talloc.bin>


More information about the samba-technical mailing list