[PATCH] Harden Samba module functions

[Andreas Schneider]

On Wednesday, 31 May 2017 11:19:18 CEST Volker Lendecke wrote:
> On Wed, May 31, 2017 at 11:15:42AM +0200, Andreas Schneider wrote:
> > On Wednesday, 31 May 2017 11:03:03 CEST Volker Lendecke wrote:
> > > On Wed, May 31, 2017 at 10:48:09AM +0200, Andreas Schneider via samba-
> > 
> > technical wrote:
> > > > > The same here, why do we need to skip loading the module depending
> > > > > on
> > > > > a specific name at all, I'd like to avoid a having this code at all.
> > > > 
> > > > If the module is in the modules directory, smbd automatically loads it
> > > > ...
> > > 
> > > Can't you change the dummy module to be less harmful, so that it can
> > > be loaded?
> > 
> > If you have a better idea how to fail if the module gets loaded ...
> 
> Can you describe the bigger picture? Do you need to test the failure
> paths for module initialization failure?

We have a test and in that test we want to make sure that the tests fails if 
the module is loaded using the absolute path. So if the module is loaded we 
need to fail the test ...

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org