[PATCH] Add conditional compilation for crypt_r

[Volker Lendecke]

On Wed, May 31, 2017 at 03:09:50PM +1200, Gary Lockyer wrote:
> Patch attached.
> 
> Review and Push appreciated.

Reviewed-by: me, this fixes this particular issue. Another team
reviewer?

However, now the next build failure comes up:

../source4/dsdb/samdb/ldb_modules/password_hash.c:1552:4: error:
format specifies type 'char *' but the argument has type 'int'
[-Werror,-Wformat]
                        strerror_r(errno, buf, sizeof(buf)));
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

"man strerror_r" on debian says that in glibc there's a posix
compatible version returning int and a GNU version returning a char *.

FreeBSD only has the posix compatible version and thus fails this
check.

I think we need to create something in lib/replace to unify both
behaviours with proper configure checks.

Can you take care of that?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de