[PATCH] Moving the VFS to struct smb_filename.

Jeremy Allison jra at samba.org
Tue May 30 18:01:53 UTC 2017

On Tue, May 30, 2017 at 09:59:36AM +0200, Ralph Böhme wrote:
> > processing...
> found a few issues, all fixed in the attached patchset:
> sys_acl_set_file_tdb: not freeing smb_fname from talloc_tos
> solarisacl_sys_acl_set_file: struct smb_filename smb_fname not declared as pointer variable
> vxfs_remove_xattr: missing declaration of struct smb_filename *smb_fname
> vxfs_remove_xattr: use after free of smb_fname when calling vxfs_removexattr_path
> vxfs_set_xattr: use after free of smb_fname when calling SMB_VFS_NEXT_REMOVEXATTR
> vfs_gluster_setxattr: calling glfs_setxattr with smb_fname instead of smb_fname->base_name
> vxfs_set_xattr: call to vxfs_setxattr_path still uses path instead of smb_fname_in->base_name
> Please push if you're happy with the changes.

Thanks a *LOT* for these fixes ! I tried to get everything
but it's more difficult when they are such sweeping


More information about the samba-technical mailing list