[PATCH][WIP] LDB changes for index handling and private event loops

Andrew Bartlett abartlet at samba.org
Mon May 29 19:54:16 UTC 2017

On Mon, 2017-05-29 at 11:50 +0200, Stefan Metzmacher wrote:
> Am 29.05.2017 um 07:10 schrieb Andrew Bartlett:
> > G'Day,
> > 
> > This set of patches should improve Samba's LDB performance and start us
> > on the road to lock-safe behaviour.  While not addressing the locking
> > issues, it prevents nested event loops against ldb_tdb.
> > 
> > I mark this [WIP] as I have not written the cmocka tests that I would
> > like to have over the changes and for the new APIs, but I would
> > appreciate some comments as I would like to propose it for review once
> > I get those comments.
> I've improved a few things like:
> - whitespaces and new lines in various places
> - make sure each commit compiles
> - fix bugs in ldb_build_req_common() and make it
>   more obvious to use
> - improve ldb_handle_new_child() and move logic
>   to it.
> Please have a look at the differences between your patchset
> and base further work on this one.

Thanks, I'll do that!

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list