[PATCH] Moving the VFS to struct smb_filename.
slow at samba.org
Mon May 29 19:47:13 UTC 2017
On Fri, May 26, 2017 at 04:05:22PM -0700, Jeremy Allison wrote:
> Hi all,
> As promised, this is the first set of patches
> that will be migrating *ALL* VFS calls from
> 'const char *' -> 'const struct smb_filename *'
> for Samba 4.7 (or Samba-5, whatever we decide :-).
> This first set changes the low-level sys_acl_XXXX()
> calls, followed by the XXXattr() calls.
> It actually cleans up quite a bit of the internal
> code now we can simply pass const struct smb_filename
> pointers around rather than converting to and
> from char * -> struct * and back all the time,
> so for each hunk you might see some modification
> of some of the calling functions to change from
> const char *' -> 'const struct smb_filename * also
> if it makes them cleaner.
> The patch is split into one hunk per VFS
> call, so there are currently 8 of them covering:
> 1). SMB_VFS_SYS_ACL_DELETE_DEF_FILE
> 2). SMB_VFS_SYS_ACL_GET_FILE
> 3). SMB_VFS_SYS_ACL_BLOB_GET_FILE
> 4). SMB_VFS_SYS_ACL_SET_FILE
> 5). SMB_VFS_LISTXATTR
> 6). SMB_VFS_REMOVEXATTR
> 7). SMB_VFS_SETXATTR
> 8). SMB_VFS_GETXATTR
> in turn. Passes local make test. Please
> review and push if happy ! Once these
> are in I'll start making my way up to
> the more complex calls.
More information about the samba-technical