[PATCH] Fix for crash "PANIC ...: assert failed: lease_type_is_exclusive(e_lease_type)"
slow at samba.org
Fri May 26 16:08:04 UTC 2017
On Fri, May 26, 2017 at 09:01:06AM -0700, Jeremy Allison wrote:
> On Fri, May 26, 2017 at 04:10:52PM +0200, Ralph Böhme wrote:
> > Hi!
> > Attached is a patch for bug
> > <https://bugzilla.samba.org/show_bug.cgi?id=12798>
> > The crash is triggered by stat-opens. The code before the lease optimisation had
> > the same issue, but it was not triggered with modern clients since Samba 4.5
> > when leases where used.
> > Please review & push if okay.
> > There's a second patch attached with an additional test for leases and
> > stat-opens. I stumbled across this while working out the reproducer for the
> > bug. Looks like we only grant R leases if there's an existing (stat-)open on a
> > file, while Windows happily grants RWH if requested.
> > The test is marked as known fail. I don't have the time currently to work out
> > why we're behaving differently compared to Windows and I don't want to let this
> > test rot in my private attic.
> > All patches are signed-off by metze and myself, so if noone pushes or objects,
> > I'll push on Monday.
> Great work Ralph and Metze ! RB+. I'll push today.
> How did you work out what the reproducer was ?
well, as soon as metze came up with stat-opens it was just a question of getting
the order right.
More information about the samba-technical