[Patches] The way to remove gensec_update_ev()

Andrew Bartlett abartlet at samba.org
Sun May 21 19:05:03 UTC 2017


On Sun, 2017-05-21 at 13:12 +0200, Stefan Metzmacher wrote:
> 
> The compiler doesn't believe tevent_req_nterror() only returns true on
> NT_STATUS_IS_OK().
> 
> This diff removes the warning
> 
> @@ -161,7 +161,7 @@ static struct tevent_req
> *gensec_ntlmssp_update_send(TALLOC_CTX *mem_ctx,
>         struct tevent_req *req = NULL;
>         struct gensec_ntlmssp_update_state *state = NULL;
>         NTSTATUS status;
> -       uint32_t i;
> +       uint32_t i = 0;
> 
> Is it ok to squash that to the "auth/ntlmssp: add implement
> gensec_ntlmssp_update_send/recv()" commit and push everything?

Yes.  (And I've done that)

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list