[PATCH] pathname cleanups

[Uri Simchoni]

On 05/19/2017 09:37 AM, Volker Lendecke wrote:
> On Fri, May 19, 2017 at 09:11:49AM +0300, Uri Simchoni via samba-technical wrote:
>> With SMB1 clients, the @GMT comes as first path element, so the SMB1
> 
> I've seen clients where the @GMT comes next to the last path
> component. That was part of the complexity of the previous
> shadow_copy2 module.
> 
Oh I get it now. In that case I suppose that won't be inside
shadow_copy2, as interpreting the client's intent moves into the server
(where it should be, irrespective of what backend is used to implement
the previous versions). The SMB1 server might try with a modified path
(@GMT removed and timewarp field has timestamp), and fall back to
unmodified path (fall back if FLAGS2_REPARSE_PATH is not set).


>> server converts that into a timewarp element and strips it off the path
>> - that too supports regular clients which want to access
>> path/.snapshots/@GMT. Admittedly, this involves a bit of heuristics.
>> There's FLAGS2_REPARSE_PATH bit in FLAGS2 - Windows clients set it and
>> also Samba client since 4.6.x. The server can decide whether to be
>> strict about it or use the heuristic (currently smbd ignores this flag).
> 
> To support the dumb clients the heuristic would have to be to try
> inserting @GMT at all places where / now is if we lose the place the
> client sent the @GMT initially. We can't rely on the flag being set I
> believe. We're talking FreeBSD, (I believe AIX) and other custom SMB
> clients that used to work.
> 
> Volker
>