[Patches] The way to remove gensec_update_ev()

Stefan Metzmacher metze at samba.org
Thu May 18 14:31:57 UTC 2017

Am 17.05.2017 um 20:10 schrieb Stefan Metzmacher via samba-technical:
> Am 17.05.2017 um 19:56 schrieb Andrew Bartlett:
>> On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
>> technical wrote:
>>> Hi,
>>> I'm currently working on the removal of gensec_update_ev(),
>>> which relies on nested event loops to be activated.
>>> If we want to have proper support for trusted domains in the
>>> as AD DC, we need to use real async authentication because
>>> we still use a single process model for the rpc server.
>>> So the first step is to make all users of gensec_update_ev()
>>> use gensec_update_send/recv instead.
>>> Once we have that we need to make the low level auth stack async
>>> for NTLMSSP (as a server) and Kerberos (as a client).
>>> Here's the first chunk of patches, they passed a private autobuild.
>>> Please review and push:-)
>> I'm looking at these now.  I'm correcting a couple of minor issues in
>> commit messages (patch of patches attached), but I also noticed:
>> Subject: [PATCH 25/35] auth/ntlmssp: add implement
>>  gensec_ntlmssp_update_send/recv()
>> -	if (!out_mem_ctx) {
>> -		/* if the caller doesn't want to manage/own the
>> memory,
>> -		   we can put it on our context */
>> -		out_mem_ctx = ntlmssp_state;
>> I don't think it is used, but can we have this as a distinct commit? 
>> I'm sorry to be petty, but it is hard enough reading the change to
>> async without also removing this at the same time.
> Ok, no problem.

Done, the result is in

I've added your review to the last 24 patches (of chunk 2),
the first 39 don't have review tags yet.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170518/231abef2/signature.sig>

More information about the samba-technical mailing list