[Patches] The way to remove gensec_update_ev()

Andrew Bartlett abartlet at samba.org
Wed May 17 18:32:58 UTC 2017

On Wed, 2017-05-17 at 14:43 +0200, Stefan Metzmacher via samba-
technical wrote:
> Hi,
> here's the next chunk on top.

This looks pretty good.  It would be great to get another set of eyes
on it, but I'm still happy to say:

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

In the small notes department:

Subject: [PATCH 24/24] s4:libcli/ldap: just use gensec_update() in

You could indicate that resolving this requires also resolving the
general case in LDB, as that is the API this is used from.  We would
need ldb_connect_send() and ldb_connect_recv() at a start. 

> Both are combined the following branch:
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-tmp
> contains the change for the LDAP server, which also pass a private
> autobuild, but it needs some more tests to be written.
> While
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec
> contains the unfinished parts:
> - source4/libcli/smb_composite/sesssetup.c
> - source4/lib/http/http_auth.c
> - auth/gensec/spnego.c
> While auth/gensec/spnego.c is the most difficult and time consuming part.

I'll also take a peek at these and see where you are going. 

Thanks for all the hard work here!

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list