[PATCH][SMB1] SMB_INFO_ALLOC return UINT_MAX rather than cut at 4-byte

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat May 13 07:30:21 UTC 2017

Hi, Peter!

On Fri, May 12, 2017 at 01:51:30PM +0000, Peter Somogyi via samba-technical wrote:
> Please accept this trivial patch that fixes allocation info query for an 
> AIX client (df command returning weird values).
> Easy to reproduce by executing smbtorture raw.qfsinfo (with > 4 TB on the 
> server side) + capturing a network trace to see the wrong values.
> Changing the 'block size' param might be a workaround, but not the 
> preferred solution.

Looks good, thanks! However,

dsize = MIN(dsize, UINT32_MAX);
dfree = MIN(dfree, UINT32_MAX);

has a few lines less. What do you think?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list