[PATCH] libads: abstract out SASL wrapping code

Jeremy Allison jra at samba.org
Fri May 12 22:45:34 UTC 2017

On Fri, May 12, 2017 at 02:33:01PM -0700, Jeremy Allison via samba-technical wrote:
> On Fri, May 05, 2017 at 08:24:43PM +0300, Alexander Bokovoy via samba-technical wrote:
> > Hi,
> > 
> > this is a preparatory patch to allow libads to user LDAP management via
> > smbldap instead of doing that directly. The patch has no functional
> > changes yet but untangles SASL code from direct use of ADS structure
> > (apart from initialization).
> > 
> > It compiles but I haven't tested yet. Please review.
> LGTM Alexander, simple wrap replace. Let's see if it goes
> through autobuild :-).

Fails with:

Join failed
SOCKET_WRAPPER_DEFAULT_IFACE="29" RESOLV_WRAPPER_HOSTS="/space/jra/src/samba/git/master/st/dns_host_file" KRB5_CONFIG="/space/jra/src/samba/git/master/st/ad_member/lib/krb5.conf" SELFTEST_WINBINDD_SOCKET_DIR="/space/jra/src/samba/git/master/st/ad_member/winbindd" ./bin/net join -s /space/jra/src/samba/git/master/st/ad_member/lib/server.conf -UAdministrator%locDCpass1 at /space/jra/src/samba/git/master/selftest/target/Samba3.pm line 469.
failed to start up environment 'ad_member' at /space/jra/src/samba/git/master/selftest/target/Samba.pm line 49.
samba can't start up known environment 'ad_member' at /space/jra/src/samba/git/master/selftest/selftest.pl line 929.
[47(651)/2098 at 15m27s, 1 errors] samba.tests.pam_winbind(ad_member)
ERROR: Testsuite[samba.tests.pam_winbind(ad_member)]
REASON: unable to set up environment ad_member - exiting

Sorry Alexander, I'll re-review once you've got it
passing local make test !


More information about the samba-technical mailing list