[PATCH] Add 'net rpc user' tests

[Christian Ambach]

Am 11.05.17 um 02:03 schrieb Jeremy Allison via samba-technical:
> On Tue, May 09, 2017 at 08:59:14AM +0200, Andreas Schneider via samba-technical wrote:
>> On Monday, 8 May 2017 13:17:16 CEST Alexander Bokovoy via samba-technical 
>> wrote:
>>>> +#!/bin/sh
>>>> +# Blackbox tests for 'net rpc'
>>>> +#
>>>> +# Copyright (c) 2017      Andreas Schneider <asn at samba.org>
>>>> +
>>>> +if [ $# -lt 4 ]; then
>>>> +cat << EOF
>>>> +Usage: net_rpc.sh SERVER ADMIN_ACCOUNT ADMIN_PASSWORD
>>>
>>> You pass and accept four arguments but 'Usage:' string only mentions
>>> three.
>>
>> Fixed, see attached patch.
>>
>>
>> Thanks for the review.
> 
> LGTM. Pushed !
> 

Should a test not also check some assertions on the desired effects?
Just checking the return code seems a bit minimal to me. We could
replace the code of the net tool with the famous "Hello, World" code and
the test would still pass.

Cheers,
Christian