Changing a commit after sign-off from someone else (was Re: [PATCHSET] support FSCTL_DUPLICATE_EXTENTS_TO_FILE)

David Disseldorp ddiss at
Mon May 8 15:50:15 UTC 2017

On Mon, 8 May 2017 11:05:38 +0200, Ralph Böhme via samba-technical wrote:

> > For the kernel this is a pretty common way of flagging changes which
> > have been made after an author (aaptel) has added his sign off:
> >
> > If Aurélien says that he's fine with the change as it is now, then I'll
> > drop the line completely.  
> yup. But afaict for us the signed-off tag already implies the person worked on
> the patch and they all jointly agree that the state of the patch is ok. So I
> don't really see a need for this extra flag.

I dropped the message here, but IMO such a message is courteous if you
make a change to a commit after the author has already signed off, for
the reasons given in the kernel guide:
" is very impolite to change one submitter's code and make him
 endorse your bugs" :-)

Cheers, David

More information about the samba-technical mailing list