[PATCHSET] support FSCTL_DUPLICATE_EXTENTS_TO_FILE
ddiss at suse.de
Mon May 8 15:37:14 UTC 2017
On Mon, 8 May 2017 16:29:30 +0200, Ralph Böhme wrote:
> On Mon, May 08, 2017 at 04:01:16PM +0200, David Disseldorp wrote:
> > On Mon, 8 May 2017 11:05:38 +0200, Ralph Böhme wrote:
> > > On Mon, May 08, 2017 at 02:22:11AM +0200, David Disseldorp wrote:
> > > > Thanks a lot for the review, Ralph!
> > > >
> > > > Please find a version 2 patchset attached. Further comments below...
> > >
> > > better, but now it has a memory leak. :)
> > Ah, I take it you mean the free of the subreq before it's cleaned up by
> > the parent req. Following convention we should then also do the same in
> > smb2_ioctl_filesys_dup_extents_done().
> You mean like in the convention of avoiding memory leaks? Yes! :)
It's a talloc child of the parent ioctl request, so will be freed with
that. Still worth fixing though :)
> > > Fix for that and an additional fixup attached.
> > Looks good - please find one further patch attached, which I'll squash
> > in if you're okay with it.
> lgtm. Can you please send the final patchset so I can take a final look?
See attached. Your sign-off is on all except 04/10.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 43513 bytes
Desc: not available
More information about the samba-technical