David Disseldorp ddiss at suse.de
Mon May 8 14:01:16 UTC 2017

On Mon, 8 May 2017 11:05:38 +0200, Ralph Böhme wrote:

> On Mon, May 08, 2017 at 02:22:11AM +0200, David Disseldorp wrote:
> > Thanks a lot for the review, Ralph!
> > 
> > Please find a version 2 patchset attached. Further comments below...  
> better, but now it has a memory leak. :)

Ah, I take it you mean the free of the subreq before it's cleaned up by
the parent req. Following convention we should then also do the same in

> Fix for that and an additional fixup attached.

Looks good - please find one further patch attached, which I'll squash
in if you're okay with it.


> > > I don't see clone-range on the wire, trace attached. Am I missing something?  
> > 
> > Interesting, thanks for checking this. I've been using the cifs.ko
> > client until now.  
> ah, ok. Which kernel version do I need? I have 4.10.13-200.fc25.x86_64

It went in with 02b1666544c08e245cb4e2253ed575f8128943d6, which was
first carried in 4.2, so cp --reflink should trigger it on your system.

Cheers, David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-SQUASH-further-minor-cleanups-following-Ralph-s-revi.patch
Type: text/x-patch
Size: 1701 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170508/48a2c23f/0001-SQUASH-further-minor-cleanups-following-Ralph-s-revi.bin>

More information about the samba-technical mailing list