[PATCH] Add 'net rpc user' tests

[Alexander Bokovoy]

On pe, 05 touko 2017, Andreas Schneider wrote:
> On Friday, 5 May 2017 18:08:54 CEST Alexander Bokovoy wrote:
> > On pe, 05 touko 2017, Andreas Schneider via samba-technical wrote:
> > > Hi,
> > > 
> > > on Tuesday I thought that I found a bug in 'net rpc user password' but it
> > > turned out it works just fine. However here is a test to confirm it.
> > > 
> > > 
> > > This is also a really simple example how to write a blackbox test in our
> > > environment.
> > > 
> > > 
> > > Review and push much appreciated.
> > 
> > -ENOPATCH
> 
> Oops

> From ce5482172848b6a7d5130bed4e15ea70460bc9d4 Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Tue, 2 May 2017 12:31:48 +0200
> Subject: [PATCH] testprogs: Add 'net rpc user' test against AD DC
> 
> Signed-off-by: Andreas Schneider <asn at samba.org>
> diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py
> index 47d71d2..c173bea 100755
> --- a/source4/selftest/tests.py
> +++ b/source4/selftest/tests.py
> @@ -385,6 +385,7 @@ for env in ["ad_member", "s4member", "ad_dc_ntvfs", "chgdcpass"]:
>      plantestsuite("samba4.blackbox.smbclient(%s:local)" % env, "%s:local" % env, [os.path.join(samba4srcdir, "utils/tests/test_smbclient.sh"), '$SERVER', '$SERVER_IP', '$USERNAME', '$PASSWORD', '$DOMAIN', smbclient4])
>  
>  plantestsuite("samba4.blackbox.samba_tool(ad_dc_ntvfs:local)", "ad_dc_ntvfs:local", [os.path.join(samba4srcdir, "utils/tests/test_samba_tool.sh"), '$SERVER', '$SERVER_IP', '$USERNAME', '$PASSWORD', '$DOMAIN', smbclient4])
> +plantestsuite("samba4.blackbox.net_rpc_user(ad_dc)", "ad_dc", [os.path.join(bbdir, "test_net_rpc_user.sh"), '$SERVER', '$USERNAME', '$PASSWORD', '$DOMAIN'])
>  
>  if have_heimdal_support:
>      for env in ["ad_dc_ntvfs", "ad_dc"]:
> diff --git a/testprogs/blackbox/test_net_rpc_user.sh b/testprogs/blackbox/test_net_rpc_user.sh
> new file mode 100755
> index 0000000..91e7661
> --- /dev/null
> +++ b/testprogs/blackbox/test_net_rpc_user.sh
> @@ -0,0 +1,56 @@
> +#!/bin/sh
> +# Blackbox tests for 'net rpc'
> +#
> +# Copyright (c) 2017      Andreas Schneider <asn at samba.org>
> +
> +if [ $# -lt 4 ]; then
> +cat << EOF
> +Usage: net_rpc.sh SERVER ADMIN_ACCOUNT ADMIN_PASSWORD
You pass and accept four arguments but 'Usage:' string only mentions
three.

-- 
/ Alexander Bokovoy