All places where file_ntimes is called have an fsp available ...

Ralph Böhme slow at
Sun May 7 06:27:57 UTC 2017

Hi Richard

On Fri, May 05, 2017 at 11:42:55AM -0700, Richard Sharpe via samba-technical wrote:
> I see that all the paths where file_ntimes is called have an fsp
> available, although sometimes it is NULL.
> Why can't we pass that on to file_ntimes so that in the cases where an
> fd is available futimens could be used rather than utimensat, for
> example.
> Might be worth some extra performance?

how comes you think futimens will be noticably faster compared to utimensat?

My approach would be to profile both versions with perf, see my talk on this
stuff from last week (once the session recordings and slides are online).


More information about the samba-technical mailing list