[PATCHES] fix owner of files created when running as root

Scott Lovenberg scott.lovenberg at gmail.com
Thu May 4 15:58:51 UTC 2017

On Thu, May 4, 2017 at 5:33 AM, Uri Simchoni via samba-technical
<samba-technical at lists.samba.org> wrote:
> On 05/04/2017 11:14 AM, Jeremy Allison via samba-technical wrote:
>> On Fri, Apr 28, 2017 at 04:49:03PM +0300, Uri Simchoni wrote:
>>> At Ctera, this has been handled with a VFS module, and I figured "this
>>> is a bug, why maintain a VFS module and not fix this".
>>> I hope this explains my reasoning. This can certainly go on as a VFS
>>> module (in-tree or private).
>> OK, I like the change - it seems to me that we could make
>> this change for 4.7.0 so long as we document it in the
>> WHATSNEW and in the smb.conf manpage.
>> Can you add a patch that adds these, then I'll review
>> the core changes ?
>> Thanks,
>>       Jeremy.
> Attached v2, no code changes but:
> - Added WHATSNEW and manpage changes
> - removed BUG: from commit messages, as this is not for backport (I'll
> close that bug).
> - removed hints of buggyness from commit messages
> - moved tests to the end (since they don't need to demonstrate a bug)
> and squashed them a bit.
> Thanks,
> Uri

Minor nit pick on a stylistic choice... This might fall into the realm
of design though, so I'd appreciate thoughts and opposing opinions.

"void take_ownership(connection_struct *conn, files_struct *fsp)"
Perhaps this should return an NTSTATUS-ish or other error code rather
than being void with multiple exit-on-failure paths?  The caller might
care that the call failed silently (other than being logged inside the

Feel free to flame me now. :)

Peace and Blessings,

More information about the samba-technical mailing list