[PATCH] Allow python3 tests to run

Petr Viktorin pviktori at redhat.com
Wed May 3 21:07:08 UTC 2017


On 05/02/2017 06:03 PM, Andreas Schneider via samba-technical wrote:
> On Tuesday, 2 May 2017 12:56:56 CEST Andrew Bartlett via samba-technical
> wrote:
>> This can't be applied yet, as the tests have regressed, but we need
>> this after the tests are fixed
>
> RB+ please push.

Here are fixes for the tests.

The s# thing is something we'll need to watch out for in the future.
I checked the ported code for more instances: it's used in 
ldb.binary_encode, but there it makes sense to accept both UTF-8-encoded 
text and binary data.


-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-python3-Use-y-instead-of-s-for-binary-data-in-PyArg_.patch
Type: text/x-patch
Size: 4319 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170503/8f276a95/0002-python3-Use-y-instead-of-s-for-binary-data-in-PyArg_.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-python3-tests-Fix-Python-3-test-issues.patch
Type: text/x-patch
Size: 1494 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170503/8f276a95/0003-python3-tests-Fix-Python-3-test-issues.bin>


More information about the samba-technical mailing list