[PATCH] Two tiny cleanups

Jeremy Allison jra at samba.org
Wed May 3 12:25:31 UTC 2017


On Wed, May 03, 2017 at 01:51:14PM +0200, vl--- via samba-technical wrote:
> Hi!
> 
> Review appreciated!

LGTM - pushed !

> From dfd4ad3b8515ea48cfc9ad04e1b6994fdcafa858 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Sun, 23 Apr 2017 18:47:05 +0200
> Subject: [PATCH 1/2] lib: Fix whitespace
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  source3/lib/ldap_escape.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/lib/ldap_escape.c b/source3/lib/ldap_escape.c
> index a731cb9..f8d4afc 100644
> --- a/source3/lib/ldap_escape.c
> +++ b/source3/lib/ldap_escape.c
> @@ -24,7 +24,7 @@
>  
>  /**
>   * Escape a parameter to an LDAP filter string, so they cannot contain
> - * embeded ( ) * or \ chars which may cause it not to parse correctly. 
> + * embeded ( ) * or \ chars which may cause it not to parse correctly.
>   *
>   * @param s The input string
>   *
> -- 
> 2.7.4
> 
> 
> From 195f0ee35d3a3c0d05adb626eca94eb0d14ddea5 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Sun, 23 Apr 2017 18:47:25 +0200
> Subject: [PATCH 2/2] lib: Fix a comment
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  source3/lib/ldap_escape.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/source3/lib/ldap_escape.c b/source3/lib/ldap_escape.c
> index f8d4afc..fa75dab 100644
> --- a/source3/lib/ldap_escape.c
> +++ b/source3/lib/ldap_escape.c
> @@ -28,8 +28,8 @@
>   *
>   * @param s The input string
>   *
> - * @return A string allocated with malloc(), containing the escaped string, 
> - * and to be free()ed by the caller.
> + * @return A string allocated with talloc(), containing the escaped string,
> + * and to be talloc_free()ed by the caller.
>   **/
>  
>  char *escape_ldap_string(TALLOC_CTX *mem_ctx, const char *s)
> -- 
> 2.7.4
> 




More information about the samba-technical mailing list