auth-logging finally merged!

[Jeremy Allison]

On Fri, Mar 31, 2017 at 01:06:11PM +0200, Michael Adam wrote:
> On 2017-03-29 at 08:55 -0700, Jeremy Allison via samba-technical wrote:
> > On Wed, Mar 29, 2017 at 09:28:51PM +1300, Andrew Bartlett via samba-technical wrote:
> > > On Wed, 2017-03-29 at 10:04 +0200, Karolin Seeger wrote:
> > > > Hi Andrew,
> > > > 
> > > > On 03/29/2017 08:38 AM, Andrew Bartlett via samba-technical wrote:
> > > > > With this, the AD DC finally has a decent authentication and
> > > > > authorization audit mechanism!
> > > > > 
> > > > > The file server also has better logging, but it isn't as
> > > > > comprehensive
> > > > > and doesn't have tests other than via the commonality with the AD
> > > > > DC.
> > > > 
> > > > congrats! :-)
> > > > 
> > > > Unfortunately, the reviewed-by tags are missing.
> > > > 
> > > > As the patches were in Garmings autobuild branch including the
> > > > reviewed-by tags, I assume that review has been granted. However, it
> > > > would have been good for the record to have them in the master
> > > > branch.
> > > 
> > > It certainly would have been, and should have been.
> > > 
> > > Sorry,
> > 
> > There is a technical fix for this you can put in the
> > git hooks/commit-msg script to ensure you have Signed-off-by
> > and Reviewed-by tags.
> 
> Right, but we should probably finally start enforcing
> on the server side.

+1 to that. Should immediately bounce commits without
the relevent SOB and RB+ lines.