ldb cmocka tests

Andreas Schneider asn at samba.org
Thu Mar 30 08:25:38 UTC 2017


On Thursday, 30 March 2017 10:03:51 CEST Andreas Schneider via samba-technical 
wrote:
> On Thursday, 30 March 2017 09:19:05 CEST Andrew Bartlett via samba-technical
> wrote:
> > On Wed, 2017-03-29 at 15:22 +0200, Andreas Schneider via samba-
> > 
> > technical wrote:
> > > > Here is a patchset from Jakub his branch
> > > > 
> > > > https://github.com/jhrozek/samba-ldb-mdb/commits/lmdb
> > > > 
> > > > which only adds some unit tests.
> > > > 
> > > > cd lib/ldb
> > > > ./configure
> > > > make -j
> > > > make test
> > > 
> > > I've enabled subunit output.
> > 
> > I've tried to integrate this (I'm chasing ldb bugs, so this seemed the
> > ideal opportunity), but it fails on a host without cmocka while trying
> > to unconditionally use the test binary.  It also overwrote the result
> > of the shell-script test suite.
> > 
> > Please squash the attached in, then work out how cmocka is expected to
> > be handled in autobuild for the samba-libs build, as samba-libs (where
> > bundling is disabled) it fails with:
> > 
> > Checking for system cmocka >=
> > 1.0                                                               : not
> > found
> > ERROR: System library cmocka of version 1.0 not found, and bundling
> > disabled
> 
> I've fixed it, but this pkg-config checking with waf is so horrible. Why do
> we need to to call CHECK_LIB in addition if pkg-config already provided
> everything.
> 
> However, patchset attached ...

This one is with ldb_rename tests!


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ldb-tests-v3.patch
Type: text/x-patch
Size: 65595 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170330/aa36e167/ldb-tests-v3-0001.bin>


More information about the samba-technical mailing list