ldb cmocka tests

[Andreas Schneider]

On Thursday, 30 March 2017 09:19:05 CEST Andrew Bartlett via samba-technical 
wrote:
> On Wed, 2017-03-29 at 15:22 +0200, Andreas Schneider via samba-
> 
> technical wrote:
> > > Here is a patchset from Jakub his branch
> > > 
> > > https://github.com/jhrozek/samba-ldb-mdb/commits/lmdb
> > > 
> > > which only adds some unit tests.
> > > 
> > > cd lib/ldb
> > > ./configure
> > > make -j
> > > make test
> > 
> > I've enabled subunit output.
> 
> I've tried to integrate this (I'm chasing ldb bugs, so this seemed the
> ideal opportunity), but it fails on a host without cmocka while trying
> to unconditionally use the test binary.  It also overwrote the result
> of the shell-script test suite.
> 
> Please squash the attached in, then work out how cmocka is expected to
> be handled in autobuild for the samba-libs build, as samba-libs (where
> bundling is disabled) it fails with:
> 
> Checking for system cmocka >=
> 1.0                                                               : not
> found 
> ERROR: System library cmocka of version 1.0 not found, and bundling
> disabled

I've fixed it, but this pkg-config checking with waf is so horrible. Why do we 
need to to call CHECK_LIB in addition if pkg-config already provided 
everything.

However, patchset attached ...



	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ldb-tests-v2.patch
Type: text/x-patch
Size: 58989 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170330/a17745c1/ldb-tests-v2.bin>