[PATCH] Remove 'samba-tool user add'

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Mar 29 13:04:58 UTC 2017


On Mon, Mar 27, 2017 at 08:28:40AM +0100, Rowland Penny via samba-technical wrote:
> On Mon, 27 Mar 2017 11:19:35 +1300
> Andrew Bartlett via samba-technical <samba-technical at lists.samba.org>
> wrote:
> 
> > On Fri, 2017-03-24 at 09:26 +0000, Rowland Penny via samba-technical
> > wrote:
> > > Hi, the attached patch will remove the 'samba-tool user add'
> > > command. I
> > > think that as it has been deprecated for over 5 years, it is time
> > > for it to go ;-)
> > > 
> > > Rowland
> > 
> > Can someone remind me why it was deprecated?
> > 
> > Thanks,
> > 
> > Andrew Bartlett
> > 
> 
> In my opinion, something is either deprecated or it isn't. In this
> case, 'samba-tool user add' was deprecated before Samba 4.0.0 was
> released. So, the question isn't why was it deprecated, it is why
> wasn't it removed before now ?
> 
> Or would you like a patch to remove the deprecate message, deprecate
> 'create' and make it 'add' again ?
> 
> This would be as stupid as deprecating something and then not removing
> it for over 5 years.

Also, shouldn't we align this with the group commands? There we have a
"samba-tool group add", but no "samba-tool group create". Is there
anything I am missing here?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

Samba eXPerience 2017, Hotel Freizeit In
2nd-4th of May 2017, http://sambaXP.org



More information about the samba-technical mailing list