[PATCH] Remove 'samba-tool user add'

[Andrew Bartlett]

On Mon, 2017-03-27 at 08:15 +0100, Rowland Penny wrote:
> On Mon, 27 Mar 2017 11:19:35 +1300
> Andrew Bartlett via samba-technical <samba-technical at lists.samba.org>
> wrote:
> 
> > On Fri, 2017-03-24 at 09:26 +0000, Rowland Penny via samba-
> > technical
> > wrote:
> > > Hi, the attached patch will remove the 'samba-tool user add'
> > > command. I
> > > think that as it has been deprecated for over 5 years, it is time
> > > for it to go ;-)
> > > 
> > > Rowland
> > 
> > Can someone remind me why it was deprecated?
> > 
> > Thanks,
> > 
> > Andrew Bartlett
> > 
> 
> In my opinion, something is either deprecated or it isn't. In this
> case, 'samba-tool user add' was deprecated before Samba 4.0.0 was
> released. So, the question isn't why was it deprecated, it is why
> wasn't it removed before now ?

Partly because it wasn't really deprecated then.  Until Samba 4.5 it
was a pure alias, with no such message.  Metze fixed that with:

commit 959384ff1843254c3d07a5856687436ea94f2da7
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Jun 2 15:15:52 2016 +0200

    samba-tool: really deprecate 'samba-tool user add'
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>


> Or would you like a patch to remove the deprecate message, deprecate
> 'create' and make it 'add' again ?
> 
> This would be as stupid as deprecating something and then not
> removing
> it for over 5 years.

To be clear, it hasn't been 5 years, indeed it hasn't been one since
the message actually got to the users (previously it was a pure alias,
as I read the patch). 

However, we have met the minimum period, it was finally announced in
4.5 so our 'rules' in this area mean we can remove it from 4.6 onwards
if we want.

The reason I asked about why is that was hoping for a more compelling
reason why this was done - it isn't like there was a unfortunate syntax
that couldn't be left during a re-structure, because it was left as an
alias!

BTW, For an idea of Samba's history to keeping our mistakes, see the
various spelling mistakes we allow as an alias in the smb.conf!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba