[PATCH] Remove 'samba-tool user add'

Martin Schwenke martin at meltin.net
Sun Mar 26 22:43:46 UTC 2017


On Mon, 27 Mar 2017 11:19:35 +1300, Andrew Bartlett via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Fri, 2017-03-24 at 09:26 +0000, Rowland Penny via samba-technical
> wrote:
> > Hi, the attached patch will remove the 'samba-tool user add' command.
> > I
> > think that as it has been deprecated for over 5 years, it is time for
> > it to go ;-)
> > 
> > Rowland  
> 
> Can someone remind me why it was deprecated?

Part of "why?":

   user add username [password]
       Create a new user. Please note that this subcommand is
       deprecated and available for compatibility reasons only. Please
       use samba-tool user create instead.

Not sure why "create" is better than "add".

Commit message doesn't say:

commit b26a4f6232219746fd8ed1b107476f3c23c6908e
Author: Theresa Halloran <thallora at linux.vnet.ibm.com>
Date:   Sun Oct 23 15:23:28 2011 -0700

    s4: samba-tool subcommand rename - change samba-tool user add to samba-tool user create
    
    Signed-off-by: Theresa Halloran <thallora at linux.vnet.ibm.com>
    Signed-off-by: Jelmer Vernooij <jelmer at samba.org>

peace & happiness,
martin



More information about the samba-technical mailing list