[PATCHES] report zero on-disk file ID to Macs
Ralph Böhme
slow at samba.org
Fri Mar 24 12:02:46 UTC 2017
On Fri, Mar 24, 2017 at 11:00:42AM +0100, Christian Ambach via samba-technical wrote:
> Hi Uri,
>
> > +static bool forced_zero_file_id;
> > +
>
> I thought one of the long-term goals was to eliminate all global
> variables. So do we really need to add another one? Can't this be stored
> in struct smbd_server_connection?
yes, that was my initial thought as well. The rest looks good, but the globals
must die, die, die. :)
Thanks a lot for taking a stab on this one Uri, I should have added this fix
ages ago!
Cheerio!
-slow
More information about the samba-technical
mailing list