[PATCH] SMB2_FIND improvement for clustered environments

[Jeremy Allison]

On Thu, Mar 23, 2017 at 01:02:02PM +0100, Stefan Metzmacher via samba-technical wrote:
> Am 23.03.2017 um 12:43 schrieb Volker Lendecke via samba-technical:
> > On Thu, Mar 23, 2017 at 11:32:23AM +0100, Ralph Böhme wrote:
> >> On Thu, Mar 23, 2017 at 11:09:16AM +0100, Volker Lendecke wrote:
> >>> On Thu, Mar 23, 2017 at 10:54:09AM +0100, Ralph Böhme via samba-technical wrote:
> >>>> This new feature is still off by default as it doesn't
> >>>> give any improvement in the non-clustered usecase.
> >>>> "smbd:async search ask sharemode" can be used to activate it,
> >>>> which makes only sense with "clustering = yes" (execept for testing).
> >>>
> >>> Can we always enable this in clustered mode, i.e. not introduce the parameter?
> >>
> >> sure. I was a bit hesitant, given the size of the change, to enable this by
> >> default. But if you and others think we should do this, I'm won't object. :)
> > 
> > It is a big change, but we won't find the bugs if people don't use it.
> > And they won't use it if it's hidden behind a parametric option. I
> > know this a difficult decision, but because this does not affect
> > functionality at all, only performance, I'm not sure a parameter is
> > the right thing to do.
> 
> Either that or we default it to yes (and may remove it later).

I just went through this code. It's *great*. Very
impressive change !

Please turn this on by default. Volker is correct
that we will not find all the bugs in this until it is
turned on by default.

+1 for 4.7.0 !!!!

Great work Ralph and Metze.