[PATCH] Correctly handle !authoritative in the rpc-based auth backends

Andrew Bartlett abartlet at samba.org
Thu Mar 23 09:03:14 UTC 2017


On Wed, 2017-03-22 at 17:00 +0100, Stefan Metzmacher wrote:
> 
> +    <para>
> +    When this parameter is set to <smbconfoption name="map untrusted
> to domain">auto</smbconfoption> smbd will
> +    deferr the mapping decision to the stack of auth method
> backends.
> +    Each auth method is able to say I'm not authoritative and the
> +    next backend will be used. This is basically the behavior
> +    implemented in Windows.
> +    </para>
> +

Thanks for documenting the change.  However the language needs some
work:  Currently it describes too closely the C level changes rather
than what changes for the user when the options are set (you can say
'assuming the default auth methods, as recommended' if you like.  Also,
the documentation shouldn't speculate about backports, this is
something we can fix when we backport.

To make progress, could we skip this part until we get a test to cover
the different values, and keep this patch set to just the "no behaviour
change"?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list