[PATCH] Updated Add detailed authentication logging for NTLM authentication.

Jeremy Allison jra at samba.org
Thu Mar 23 01:48:08 UTC 2017


On Thu, Mar 23, 2017 at 11:45:49AM +1300, Andrew Bartlett via samba-technical wrote:
> 
> We think we are finally ready to have this branch pushed to master.  
> 
> I'm currently testing if we can disconnect the tests from the messaging
> bugs I found while we debate API preferences.
> 
> If we can split it, or otherwise get past this, we hope to push as much
> possible soon, so if you or anybody else would like to review it that
> would be most helpful!
> 
> git://git.catalyst.net.nz/samba.git auth-logging
> 
> http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/a
> uth-logging
> 
> We didn't ask for formal review/push yet because we wanted to address
> the concern you raised early, that we might not work between some of
> the early commits.  We have written an extensive test suite, and run
> that between all the commits that change APIs via:
> 
> git rebase -i
> x make test TESTS=auth_log
> 
> Therefore we are now confident we do not have any of the feared issues
> there. 
> 
> This is a massive improvement in Samba's suitability for as an AD DC,
> and I'm very proud of the work done here by Gary in particular. 

Sounds good ! Can you post it as a patchset to the list as
well, or is it too big ?

Jeremy.



More information about the samba-technical mailing list