[PATCH] Remove undocumented code, fix bug 12707

Jeremy Allison jra at samba.org
Wed Mar 22 13:04:35 UTC 2017


On Tue, Mar 21, 2017 at 04:30:38PM +0100, Volker Lendecke via samba-technical wrote:
> On Tue, Mar 21, 2017 at 04:24:48PM +0100, Andreas Schneider wrote:
> > On Tuesday, 21 March 2017 16:13:28 CET Volker Lendecke via samba-technical 
> > wrote:
> > > Hi!
> > > 
> > > As I don't even remember how this module works, it is far
> > > better to remove it but to write false documentation or leave
> > > it undocumented.
> > > 
> > > Review appreciated!
> > 
> > I have customers using this module. So we can't remove it without prior 
> > announcement and I just fixed bugs in that codepath for the customer today.
> > 
> > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/master-msdfs
> > 
> > 
> > So -1 on for removal for now. If you want to remove it we should first 
> > announce it!
> 
> By the way, isn't this mail enough of an announcement?

No :-). Needs to be in the release notes or in the man
page for the module. Oh, wait... ? :-) :-).



More information about the samba-technical mailing list